Skip to content

Adapt Pipeline Graph View for standardised experimental Jenkins pages - #1317

Draft
janfaracik wants to merge 2 commits into
jenkinsci:mainfrom
janfaracik:container-ui
Draft

Adapt Pipeline Graph View for standardised experimental Jenkins pages#1317
janfaracik wants to merge 2 commits into
jenkinsci:mainfrom
janfaracik:container-ui

Conversation

@janfaracik

Copy link
Copy Markdown
Member

Screenshots incoming

Basically fixes the sticky element so they align with the sticky build bar.

For jenkinsci/jenkins#26863

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

:root {
// can be removed and `--header-height` used directly when jenkins baseline is 2.507
--pgv-header-height: var(--header-height, 45.5938px);
--pgv-header-height: 58px;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should provide a variable in Jenkins for this value...

display: grid;
gap: var(--section-padding);
animation: fade-in 0.1s ease-in-out both;
padding-bottom: calc(var(--section-padding) + 0.325rem);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns the scroll to bottom/top buttons a little nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant